Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow top-level metadata type to be a union of null, object. #659

Closed
benjeffery opened this issue Jun 1, 2020 · 0 comments · Fixed by #730
Closed

Allow top-level metadata type to be a union of null, object. #659

benjeffery opened this issue Jun 1, 2020 · 0 comments · Fixed by #730
Assignees
@benjeffery
Labels
enhancement New feature or request
Milestone
Python 0.3.0

Comments

@benjeffery
Copy link
Member

As discussed in tskit-dev/pyslim#82 empty metadata is a common occurrence when a tool is adding to an existing tree sequence. To add metadata a tool adds a schema which means default "na" values must be added to all existing rows.
We can change the metaschema to allow a union of null,object at the top-level of the schema to support a subset of rows having empty metadata. The encoders and decoders will special-case this usage.
@benjeffery benjeffery added the enhancement New feature or request label Jun 1, 2020
@benjeffery benjeffery added this to the Python 0.3.0 milestone Jun 1, 2020
@benjeffery benjeffery self-assigned this Jun 1, 2020
@benjeffery benjeffery mentioned this issue Jun 1, 2020
Closed
benjeffery added a commit to benjeffery/tskit that referenced this issue Jul 23, 2020
@benjeffery
Allow top-level metadata type to be union of null, object tskit-dev#659
cae857c
@benjeffery benjeffery mentioned this issue Jul 23, 2020
Merged
AdminBot-tskit pushed a commit to benjeffery/tskit that referenced this issue Jul 23, 2020
@benjeffery
Allow top-level metadata type to be union of null, object tskit-dev#659
ce99131
@mergify mergify bot closed this as completed in #730 Jul 23, 2020
mergify bot added a commit that referenced this issue Jul 23, 2020
@mergify
Merge pull request #730 from benjeffery/top-level-metadata-null-union
9398b9a 
Allow top-level metadata type to be union of null, object #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjeffery benjeffery

Labels
enhancement New feature or request
Projects
None yet
Milestone
Python 0.3.0
Development

Successfully merging a pull request may close this issue.

Allow top-level metadata type to be union of null, object #659 benjeffery/tskit
1 participant
@benjeffery