Update tskit #89
Update tskit #89
Conversation
pyslim/slim_metadata.py
Outdated
| "is_null": { | ||
| "type": "integer", | ||
| "description": "Whether this node describes a 'null' (non-existant) chromosome.", | ||
| "binaryFormat": "B", |
There was a problem hiding this comment.
How come this isn't a ? (bool). The example below suggests it is.
There was a problem hiding this comment.
That's because in the SLiM code they're defined as uint8_t. Maybe this would all work out fine and be equivalent? I don't know?
There was a problem hiding this comment.
but, they are boolean, yes.
There was a problem hiding this comment.
I think bool size is compiler-dependant in C++ so SLiM needs to be specify uint8_t. In python ? will always be one-byte. Should all work out fine.
There was a problem hiding this comment.
Ok - so I'll leave it as-is (right?).
There was a problem hiding this comment.
I think @benjeffery was saying we need to use ? in the schema, and make sure that the corresponding value in SLiM is always a uint8_t; we should never used b or B in the schema, and we should never use bool in the corresponding C++ code. Do I have that right?
There was a problem hiding this comment.
Yes, ? In python uint_8 in C++. Sorry I wasn't clearer!
There was a problem hiding this comment.
Oh, I got it. =)
There was a problem hiding this comment.
fixed in 7534d9b
petrelharp
force-pushed
the
update_tskit
branch
from
151875a to
7534d9b
Compare
dump reference sequence; closes #84 mut time test slim is using metadata test file version test versus old metadata decoding benchmark script readme note .
petrelharp
force-pushed
the
update_tskit
branch
from
829bcf4 to
2a3529a
Compare
This goes along with MesserLab/SLiM#101 and supercedes #82.