-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parenthesis in when clause in wrapper keybindings generator #296
Comments
tshino
added a commit
that referenced
this issue
Oct 15, 2023
tshino
added a commit
that referenced
this issue
Oct 19, 2023
tshino
added a commit
that referenced
this issue
Oct 20, 2023
tshino
added a commit
that referenced
this issue
Oct 21, 2023
tshino
added a commit
that referenced
this issue
Oct 22, 2023
tshino
added a commit
that referenced
this issue
Dec 10, 2023
tshino
added a commit
that referenced
this issue
Dec 10, 2023
tshino
added a commit
that referenced
this issue
Dec 12, 2023
tshino
added a commit
that referenced
this issue
Dec 13, 2023
tshino
added a commit
that referenced
this issue
Dec 23, 2023
tshino
added a commit
that referenced
this issue
Dec 24, 2023
tshino
added a commit
that referenced
this issue
Dec 25, 2023
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've found that parenthesis support has been introduced as part of the
when
clause context from VS Code 1.77.microsoft/vscode#175540
If parentheses are used in the default keybindings or any keymap extensions that we support, this extension will require changes to support them in wrapper generator scripts described in below:
https://github.com/tshino/vscode-kb-macro/blob/main/DESIGN.md#default-keybindings-wrappers
In order to generate the wrapper keybindings, it is needed to tweak the every
when
context. And in the test, we need to analyze them to verify that the result should work. And those functionalities have been implemented based on the good old when clause which was much simpler to be parsed than now. So now we should do some additional work to support the new grammar in the scripts.At least following functions should be investigated:
addWhenContext(when, context)
in gen_wrapper_util.jsnegateContext(context)
in gen_wrapper_util.jscontainsWhenContext(when, context)
in verify_wrapper.jsremoveWhenContext(when, context)
in verify_wrapper.jsjoinComplementalKeybindings(keybindings)
in verify_wrapper.jsA keymap extension that is possibly about to introduce parentheses: (Thankfully, this made me aware of the issue. 😂)
The text was updated successfully, but these errors were encountered: