Various minor tweaks #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We _ought_ to add node-inspector to the devDependencies to enable the test:debug script, but that would currently break `npm install` for folks on node v7 because of node-inspector/node-inspector#950. For now, contributors will have to install node v6 or lower and manually `npm install node-inspector`.
|
This is awesome! Great PR :) node-inspector looks pretty sweet and I like the ability to selectively run tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have added node-inspector the devDependencies in order to enable the test:debug script, but that would currently break
npm installfor folks on node v7 because of node-inspector/node-inspector#950.For now, I've documented that
npm install node-inspectorhas to be run manually on node v6 or lower.