Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making updates we discussed #12

Merged
merged 6 commits into from
Feb 3, 2024
Merged

Conversation

handwerkerd
Copy link

@handwerkerd handwerkerd commented Oct 20, 2023

I'm making the updates we discussed in ME-ICA#959 (comment)

Changes proposed in this pull request (check marks are done):

  • Move all info from log_extra_report to _comments in minimal.json and removed that field from that file
  • Changed the ID for the tree from minimal_decision_tree_test1 to minimal_decision_tree and updated a test which checked for the ID (should have done that earlier)
  • Added a placeholder reference to references.bib
  • Add a real reference to references.bib when I create the project with a DOI on figshare
  • Merge Lint codebase with additional style restrictions ME-ICA/tedana#970 into this tree
  • Move all info from log_extra_report to _comments in kundu.json and removed that field from that file
  • Depending how I feel, address Remove log_extra_report from decision tree configs ME-ICA/tedana#982 in this PR

@tsalo, it's your choice if you want to periodically merge my changes into your main PR or to wait until it's closer to done.

@tsalo tsalo merged commit 2e4f290 into tsalo:doc-tree Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants