Refactor Fit #1
Refactor Fit #1
Conversation
|
@TomMaullin thanks so much for this PR. It looks pretty good to me, although there are a couple of things I'd like to tweak. Unfortunately, between updates to my fork and who knows what else, GitHub is being less than cooperative. Since I'm not very proficient with command line git (which seems to be necessary to resolve the current conflicts), would you mind pulling from my current master to eliminate those conflicts? |
Patches: * csstepdata saved as JSON rather than a text dump * Removes unused imports in test.utils to fix linting errors
|
Hi @tsalo , Sure! I've merged this with the master! Again I didn't have time to get this code running and test how well it worked but hopefully, as my edits were quite simple, it should be quite easy to see where I have made them and, if there are any errors, hopefully * touch wood * they shouldn't be too difficult to resolve. |
|
@TomMaullin This looks great, thanks! I'll merge now and check the CI results after. There's always the possibility we'll need to squash a bug or two, but the code makes sense to me. |
[ENH,FIX] Fixing decision tree workflow
Changed default compute_zvalues of get_coeffs to False
Hi, I'm not sure if this is too late but I have refactored the code mentioned in issue ME-ICA#25 on the ME-ICA repository. I'm afraid I have run out of time before managing to test it but perhaps this will still save someone a few minutes at some point!