Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/build-and-test-cuml-22.08+ #83

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Oct 19, 2022

  • Adds the -DFIND_CUML_CPP=ON flag to the build-cuml-python function.
  • Running the pytest python tests from within the cuml/python directory
    triggers an error, because pytest_plugins must be configured in the root
    conftest.py module as of pytest version 4.0.

Running the pytest python tests from within the cuml/python directory
triggers an error, because pytest_plugins must be configured in the root
conftest.py module as of pytest version 4.0.
@csadorf csadorf marked this pull request as draft October 19, 2022 17:12
@csadorf
Copy link
Contributor Author

csadorf commented Oct 19, 2022

The changes were likely needed after the merge of rapidsai/cuml#4818 .

@csadorf csadorf force-pushed the fix/build-and-test-cuml-22.08+ branch from 6c588bc to 02d2c42 Compare October 21, 2022 08:52
@csadorf csadorf marked this pull request as ready for review October 21, 2022 09:04
@csadorf
Copy link
Contributor Author

csadorf commented Oct 21, 2022

@trxcllnt I've tested this a bit and everything seems to work fine. Should be ready to merge.

@trxcllnt trxcllnt merged commit 984bdcf into trxcllnt:main Oct 21, 2022
@csadorf csadorf deleted the fix/build-and-test-cuml-22.08+ branch October 24, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants