EIP1559 New fee support #1509
Merged
EIP1559 New fee support #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 30, 2021 16:38
|
how to calculate |
I have not came across a guide targeted at wallet developers. |
vikmeup
approved these changes
Jul 15, 2021
|
Put back to Draft, some small changes planned. |
hewigovens
approved these changes
Jul 26, 2021
|
EIP1559 has been activated on Ethereum mainnet, time to merge this. |
vikmeup
approved these changes
Aug 5, 2021
| bytes max_inclusion_fee_per_gas = 8; | ||
|
|
||
| // Maxinmum fee (256-bit number) | ||
| // Used only for EIP1559 fee, disregarded for legacy |
There was a problem hiding this comment.
do you think we can order properties by index? to avoid confusion in the future
There was a problem hiding this comment.
Not sure what's the best approach:
- change index numbers to match the order --> risk of breaking binary usage (had issues in the past)
- reorder in the source code to match indexes --> confusing, items close logically end up separates
- keep as it is
SHH-HaoZhang
pushed a commit
to monacohq/wallet-core
that referenced
this pull request
Oct 15, 2021
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() * Eip1559 tx implementation (native transfer only). * Additional EIP1559 build methods * Revert renumbering in proto file (to be bw compatible) * Additional tests for 1559-fee'd ERC20 and other 3 messages * Test fix * iOS test data fix * Android test fix * Update coverage (94.6%) * Merge fix * Merge fix * Add comment on replay protection * Empty (access) list as const. Co-authored-by: Catenocrypt <[email protected]> Co-authored-by: hewigovens <[email protected]>
cornbread78
pushed a commit
to cornbread78/wallet-core
that referenced
this pull request
Dec 22, 2021
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() * Eip1559 tx implementation (native transfer only). * Additional EIP1559 build methods * Revert renumbering in proto file (to be bw compatible) * Additional tests for 1559-fee'd ERC20 and other 3 messages * Test fix * iOS test data fix * Android test fix * Update coverage (94.6%) * Merge fix * Merge fix * Add comment on replay protection * Empty (access) list as const. Co-authored-by: Catenocrypt <[email protected]> Co-authored-by: hewigovens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New EIP1559 fee structure support. Fixes #1322.
Note: Ethereum proto and binary format changed.
Testing instructions
New EIP1559-fee TX, tested on Ropsten testnet.
Unit tests.
Types of changes
Checklist
[WIP]if necessary.