feat: Add did:web resolver #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1431 +/- ##
==========================================
- Coverage 87.95% 87.88% -0.08%
==========================================
Files 207 208 +1
Lines 19487 19534 +47
==========================================
+ Hits 17140 17167 +27
- Misses 1494 1510 +16
- Partials 853 857 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bstasyszyn
reviewed
Aug 18, 2022
| decodedPathAndPort := strings.ReplaceAll(decodedPath, "%3A", ":") | ||
|
|
||
| // TODO: this is did:web rule - do we need to deal with http domains? | ||
| urlStr := "https://" + decodedPathAndPort |
There was a problem hiding this comment.
There's a startup parameter that dictates whether we use http: enableDevMode.
There was a problem hiding this comment.
@bstasyszyn Removed, this code (check with current domain) is not required.
- Calculate orb identifier from web identifier - Resolver document - Transform orb document into web document Closes trustbloc#1426 Signed-off-by: Sandra Vrtikapa <[email protected]>
bstasyszyn
approved these changes
Aug 18, 2022
fqutishat
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1426
Signed-off-by: Sandra Vrtikapa [email protected]