Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: All uswds scss modules now applied in Storybook #696

Closed
wants to merge 3 commits into from

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Dec 9, 2020

Summary

Fix #191 and add comments in other stylesheet files to better explain whats happening.

Related Issues or PRs

resolves #191

How To Test

  • Hover on footer nav links should show blue color (if not already visited). If your links have already been visited you may need to clear history for localhost.

@haworku haworku added type: bug Something isn't working like it's supposed to type: documentation Improvements or additions to documentation labels Dec 9, 2020
@haworku haworku self-assigned this Dec 9, 2020
@haworku haworku requested a review from ahobson as a code owner December 9, 2020 18:42
@haworku haworku marked this pull request as draft December 9, 2020 22:22
@haworku
Copy link
Contributor Author

haworku commented Dec 9, 2020

Turning back to draft since Happo is showing some interesting discrepancies that I will look into more.

- currently breaking due to Storybook not being 8+ postcss-loader
- error message: Error: PostCSS plugin autoprefixer requires PostCSS 8.
@haworku
Copy link
Contributor Author

haworku commented Dec 21, 2020

This ticket adds all USWDS scss to Storybook in order to use custom variables. However, the change is causing some components to break in certain browsers as seen in the Happo diff and the screenshot below. This seems like an autoprefixing issue.

Notes:

  • UWSDS scss requires autoprefixing to work (see USWDS installation docs - Sass Compilation Requirements).
  • We need to adjust Storybook webpack configuration to do this, for example by using autoprefixer and postcss-loader). It is a relatively a simple change, particularly since Storybook already includes the postcss-loader.
  • However 😇 Storybook's version is of postcss-loader is out of date. It needs to be updated to version 8+ to work, which is well documented. So right now everything breaks when we add autoprefixing (see 3a14ad0 ).
  • In the screenshot below the left side is the changes from this ticket, the right is whats on our live storybook. You can see the autoprefixing issue in the CSS
    Screen Shot 2020-12-21 at 10 36 29 AM

@haworku haworku added the status: wontfix This will not be worked on (either now or ever) label Dec 22, 2020
@haworku
Copy link
Contributor Author

haworku commented Dec 22, 2020

Closing as "won't fix" due to reasons described in #191

@haworku haworku closed this Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix This will not be worked on (either now or ever) type: bug Something isn't working like it's supposed to type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] uswds typography mixin not being applied in storybook
1 participant