Utilize correct MESSAGE_SIZE #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to commit 1d97873, this value was calculated properly. It was then switched to ctap_types::sizes::REALISTIC_MAX_MESSAGE_SIZE, which was then removed from the ctap_types package, and it was hardcoded at 3072 for an unknown reason in a2104a2.
This PR modifies it back to correctly calculating it as a function of the packet size (giving a max of 7609 with a packet size of 64). The hardcoded 3072 value is insufficient for new post-quantum cryptography algorithms, hence the request to increase it.