Upstream changes from the Nitrokey firmware repository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of usize::to_be_bytes depends on the size of the pointer on the targeted cpu architecture
This doesn't change the panic risk. The internal `rp_mut` method uses the `unreachable!` macro
When using highspeed usb, some calculations worked with usb 1 constants. This caused packets to be handled improperly.
This makes the distinction clearer between the length of the USB packet and the length of the data its CCID header references
robin-nitrokey
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include some better error reporting and readability improvements. It also removes the use of undocumented APIs from interchange and fixes two bugs:
This includes some breaking changes though.
It also looks like too much of the crate is
public. I'll make another PR adressing that.