Remove store! macro #202
Merged
Remove store! macro #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the store! macro. The macro was very complex, intransparent and hard to understand and contained lots of unsafe code and mutable statics. Software runners can instead just use virt::Store and virt::StoreConfig. Embedded runners typically have better means to safely implement the required statics and should create their own Store implementation. This is anyway necessary in most use cases as the runner will need more robust error handling than what was provided by the store! macro. As a side effect, this allows us to make the littlefs2 dependency optional unless the virt feature is selected.
daringer
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the store! macro. The macro was very complex, intransparent and hard to understand and contained lots of unsafe code and mutable statics. Software runners can instead just use virt::Store and virt::StoreConfig. Embedded runners typically have better means to safely implement the required statics and should create their own Store implementation. This is anyway necessary in most use cases as the runner will need more robust error handling than what was provided by the store! macro.
As a side effect, this allows us to make the littlefs2 dependency optional unless the virt feature is selected.