Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error message for tool version error #655

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ctron
Copy link
Collaborator

@ctron ctron commented Dec 20, 2023

In case of using --offline, and requiring a specific version of a tool, the error just says "not found". However, it would be more helpful to indicate that the tool was found, but was of the wrong version ("version mismatch").

Closes: #650

@ctron ctron added this to the 0.18.3 milestone Dec 20, 2023
In case of using --offline, and requiring a specific version
of a tool, the error just says "not found". However, it would
be more helpful to indicate that the tool was found, but was
of the wrong version ("version mismatch").

Closes: trunk-rs#650
@ctron ctron force-pushed the feature/impr_err_1 branch from 274566e to a79eae3 Compare December 20, 2023 09:07
@ctron ctron merged commit f9f393a into trunk-rs:main Dec 20, 2023
@ctron ctron deleted the feature/impr_err_1 branch December 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trunk build --offline fails to find wasm-bindgen even when available in PATH
1 participant