Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply correct top level mode to worker loader script #642

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ctron
Copy link
Collaborator

@ctron ctron commented Dec 18, 2023

Closes #643

@ctron ctron added the bug Something isn't working label Dec 18, 2023
@ctron ctron added this to the 0.18.2 milestone Dec 18, 2023
@ctron
Copy link
Collaborator Author

ctron commented Dec 19, 2023

I also tested this PR again the provided example: https://github.com/yewstack/yew/tree/master/examples/web_worker_prime … it does fix the issue for me.

@ctron ctron merged commit ee96821 into trunk-rs:main Dec 19, 2023
5 checks passed
@ctron ctron deleted the feature/minify_worker_1 branch December 19, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yew workers broken since 0.18 due to minification: Can't find variable: wasm_bindgen
1 participant