Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling SRI and minification #635

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

ctron
Copy link
Collaborator

@ctron ctron commented Dec 17, 2023

Both features seem to cause issues for some people. And while it's a good thing to have them by default, there should be a way out if they cause trouble. Or are not desired.

@ctron ctron force-pushed the feature/disable_opts_1 branch from bf98834 to ad2a44a Compare December 17, 2023 16:41
@ctron
Copy link
Collaborator Author

ctron commented Dec 17, 2023

Workaround for: #634, #633, #629

@ctron
Copy link
Collaborator Author

ctron commented Dec 17, 2023

For #633 this might actually be the fix. As yes, trunk 0.18.0 is a breaking change.

@ctron ctron force-pushed the feature/disable_opts_1 branch from 4bd6a1d to b346e56 Compare December 17, 2023 17:05
Both features seem to cause issues for some people. And while it's a
good thing to have them by default, there should be a way out if they
cause trouble. Or are not desired.
@ctron ctron force-pushed the feature/disable_opts_1 branch from b346e56 to 23c1b87 Compare December 17, 2023 17:13
@ctron ctron merged commit 2116e89 into trunk-rs:main Dec 17, 2023
5 checks passed
@ctron ctron deleted the feature/disable_opts_1 branch December 17, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant