Add config option to specify additional headers for serve #322

oberien · 2022-02-17T20:01:14Z

I'm using webworkers (based on #285) and want to use SharedArrayBuffer. That requires setting the headers Cross-Origin-Opener-Policy: same-origin and Cross-Origin-Embedder-Policy: require-corp. To allow this configuration during development with trunk serve, I added a config option which allows specifying any number of header-value pairs, which are included in responses.

Fix #414

Checklist

Updated CHANGELOG.md describing pertinent changes.
Updated README.md with pertinent info (may not always apply).
Updated site content with pertinent info (may not always apply).
Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 🤓.

iTitus · 2022-06-20T18:18:12Z

Is there any update on this?
I'd like to add CORS headers in my local dev env.

thedodd

One nit (which CI should have caught, we'll update later). Will be g2g after that.

thedodd · 2022-06-30T03:07:17Z

src/serve.rs

@@ -19,6 +19,8 @@ use crate::common::SERVER;
 use crate::config::RtcServe;
 use crate::proxy::{ProxyHandlerHttp, ProxyHandlerWebSocket};
 use crate::watch::WatchSystem;
+use axum::http::header::HeaderName;
+use std::collections::HashMap;


Let's move these imports up to where their other related imports take place. axum::http:: is already being imported, so let's group those. Then for std::collections::HashMap, let's move that up to line 1 (alphabetical order).

oberien · 2022-07-03T15:43:33Z

Thanks for the review. Unfortunately the changes have become pretty stale. I rebased and needed to completely change up the implementation. It works with the new ServeDir instead of the custom endpoint implementation now.

This time I ran rustfmt, so the imports should be in the correct order :)

vitvakatu · 2022-11-02T20:55:30Z

Hi, @thedodd. Is anything blocking this PR? I also faced #414 in my project. I overlooked this PR and even prepared my own. (available here, the approach is slightly different, I also updated docs and added an example)

I'd love to see this merged and released. It's quite a simple feature that helps tremendously.

SeanOMik · 2022-11-12T04:29:39Z

I also would love to see this merged. It looks like GitHub is saying that this branch is out-of-date with the base branch. I'll be willing to try to rebase it to the master and make other changes if needed.

oberien · 2022-11-12T15:28:29Z

Rebased to the latest master. Is there anything else I can do to help move this PR along? (The 2 clippy lints don't affect code I changed.)

thedodd

Very last tiny item! I'll push the merge button on this once it is done.

Thanks again for all of the great work on this.

thedodd · 2022-11-14T15:47:33Z

CHANGELOG.md

@@ -40,6 +40,7 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe
 - It is now possible to disable the hashes in output file names with the new `--filehash` flag (for example `cargo build --filehash false`). Alternatively the `build.filehash` setting in `Trunk.toml` or the env var `CARGO_BUILD_FILEHASH` can be used.
 - Flags for enabling reference types & weak references in `wasm-bindgen`.
 - Added the `data-typescript` attribute to Rust assets. When present, `wasm-bindgen` will emit TS files for the WASM module.
+- Added `headers` config option for `trunk serve`.


We should add this to the unreleased section of the changelog. Once we are ready to cut a release, it will get moved down into a specific release version.

Good catch that the automerge resulted in this artifact. Fixed.

chaosprint · 2023-02-16T14:01:33Z

Thanks for this PR. Look forward to its progress.

Cornul11 · 2023-03-15T23:57:18Z

Are there any updates on the possibility of merging this to the upstream?

github-actions · 2023-10-20T00:35:43Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

ctron · 2023-10-20T07:25:53Z

I merged this into trunk-ng, if it looks good for the next few days, it should be released as 0.17.11.

It would be great if any of you could test this feature specifically. You need to install trunk-ng from git for doing so: cargo install --git https://github.com/ctron/trunk --branch trunk-ng

oberien · 2023-10-21T19:05:56Z

I tested trunk-ng and it seems to work just fine. I can't tell a difference in behaviour between my branch and trunk-ng.

ctron · 2023-10-24T08:26:04Z

This is now released with trunk-ng 0.17.11

github-actions · 2023-12-10T00:05:55Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

oberien · 2023-12-11T08:41:54Z

This PR is not stale. The feature is used by several people and has even been integrated into trunk-ng.

ctron · 2023-12-12T08:02:05Z

This was brought back to trunk with PR #623 and it should be part of the next release of trunk too.

ctron · 2023-12-13T10:20:00Z

This was released with trunk 0.18.0.

oberien force-pushed the headers branch 2 times, most recently from 138d7cb to 0e98114 Compare February 22, 2022 08:10

oberien force-pushed the headers branch from 6fba31e to 6e94162 Compare March 29, 2022 08:20

thedodd requested changes Jun 30, 2022

View reviewed changes

oberien force-pushed the headers branch from 6e94162 to 36bfe20 Compare July 3, 2022 15:41

oberien requested a review from thedodd July 3, 2022 15:45

oberien force-pushed the headers branch from 36bfe20 to a06d1dd Compare November 12, 2022 15:05

thedodd requested changes Nov 14, 2022

View reviewed changes

Add config option to specify additional headers for serve

3e46a40

oberien force-pushed the headers branch from a06d1dd to 3e46a40 Compare November 14, 2022 15:56

github-actions bot added the Stale label Oct 20, 2023

github-actions bot removed the Stale label Oct 21, 2023

github-actions bot added the Stale label Dec 10, 2023

ctron closed this Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add config option to specify additional headers for serve #322

Add config option to specify additional headers for serve #322

oberien commented Feb 17, 2022 •

edited

Loading

iTitus commented Jun 20, 2022

thedodd left a comment

thedodd Jun 30, 2022

oberien commented Jul 3, 2022 •

edited

Loading

vitvakatu commented Nov 2, 2022

SeanOMik commented Nov 12, 2022

oberien commented Nov 12, 2022

thedodd left a comment

thedodd Nov 14, 2022

oberien Nov 14, 2022

chaosprint commented Feb 16, 2023

Cornul11 commented Mar 15, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023

ctron commented Oct 20, 2023

oberien commented Oct 21, 2023

ctron commented Oct 24, 2023

github-actions bot commented Dec 10, 2023

oberien commented Dec 11, 2023

ctron commented Dec 12, 2023

ctron commented Dec 13, 2023

Add config option to specify additional headers for serve #322

Add config option to specify additional headers for serve #322

Conversation

oberien commented Feb 17, 2022 • edited Loading

iTitus commented Jun 20, 2022

thedodd left a comment

Choose a reason for hiding this comment

thedodd Jun 30, 2022

Choose a reason for hiding this comment

oberien commented Jul 3, 2022 • edited Loading

vitvakatu commented Nov 2, 2022

SeanOMik commented Nov 12, 2022

oberien commented Nov 12, 2022

thedodd left a comment

Choose a reason for hiding this comment

thedodd Nov 14, 2022

Choose a reason for hiding this comment

oberien Nov 14, 2022

Choose a reason for hiding this comment

chaosprint commented Feb 16, 2023

Cornul11 commented Mar 15, 2023 • edited Loading

github-actions bot commented Oct 20, 2023

ctron commented Oct 20, 2023

oberien commented Oct 21, 2023

ctron commented Oct 24, 2023

github-actions bot commented Dec 10, 2023

oberien commented Dec 11, 2023

ctron commented Dec 12, 2023

ctron commented Dec 13, 2023

oberien commented Feb 17, 2022 •

edited

Loading

oberien commented Jul 3, 2022 •

edited

Loading

Cornul11 commented Mar 15, 2023 •

edited

Loading