This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add truffle library documentation #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
commented
Jul 29, 2019
| @@ -80,7 +80,7 @@ know how we can improve it! | |||
| // config_[1] starts remaining parameters. | |||
| if (config.help) { | |||
| console.log(`Usage: truffle run hello [name]`); | |||
| done(null, [], []); | |||
| done(null, [], []); | |||
There was a problem hiding this comment.
My editor made this spacing change, just noticed it. Is this line a typo anyway though?
There was a problem hiding this comment.
yes, good. little known fact: inside every trailing space lives a ferocious gremlin
There was a problem hiding this comment.
This line looks like a typo to me, done isn't part of the method signature. @gnidan @CruzMolina
There was a problem hiding this comment.
@eggplantzzz Ok .. removing.
gnidan
reviewed
Aug 12, 2019
| @@ -80,7 +80,7 @@ know how we can improve it! | |||
| // config_[1] starts remaining parameters. | |||
| if (config.help) { | |||
| console.log(`Usage: truffle run hello [name]`); | |||
| done(null, [], []); | |||
| done(null, [], []); | |||
There was a problem hiding this comment.
yes, good. little known fact: inside every trailing space lives a ferocious gremlin
Co-Authored-By: g. nicholas d'andrea <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for truffle 2226
cc: @gnidan