Close #2661 - add no-compile flag

[robertmagier]

I throw an error when flags --compile-all or --debug are used together with -compile-none
Not sure if this is the correct way to do it.

    if (config.compileAll && config.compileNone) {
      options.logger.log(
        "--compile-none can not be set together with --compile-all or --debug"
      );
      throw "Command line error.";
    }

[gnidan]

Thanks for this! Just a minor cleanup issue I spotted.

[robertmagier]

@gnidan Should I add test case for --compile-none flag scenario ?

[robertmagier]

I added test file to test how to use --compile-none flag. In last scenario this test is failing exactly as in issue #469 Can someone verify if this scenario is correct ? @gnidan ?

[robertmagier]

@gnidan @CruzMolina Pleeeease ;)

[coveralls]

Coverage increased (+0.003%) to 72.95% when pulling f06da62 on robertmagier:develop into 7c19713 on trufflesuite:develop.

[gnidan]

Ended up taking a different approach, but this should be done now as of #3208.

Sorry for the radio silence here, but I think this PR can now be closed, since that functionality now exists!

[robertmagier]

All my work for nothing.

[gnidan]

I'm really sorry about that @robertmagier! I felt awful but still decided that the alternate approach was simple enough.

Looking at this again now, however, I think your tests will provide lots of value! I'll reopen this with the plan to get these tests merged, at least!

[eggplantzzz]

Some of this work was taken and used in #3335. I gave coauthoring credit to @robertmagier. Apologies @robertmagier for letting this one become irrelevant :(

[robertmagier]

I am sorry for whining ;) Thank you for giving coauthoring credit to me as well. Let me know if you need any help here... or there.

[eggplantzzz]

It's no problem :) I hate to have good work go to waste, it has been a busy time the last year or so but we have implemented some process to help us to stay on top of contributions like this one. Is your Windows CI PR still relevant?

[eggplantzzz]

So this feature was merged in this PR and should be released next week!

[eggplantzzz]

Closing as this feature was released in version 5.1.47. Thanks!