This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
[WIP] Async Deployer #23
Open
cgewecke
wants to merge
9
commits into
next
Choose a base branch
from
async-deployer
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
commented
Jun 6, 2018
package.json
Outdated
@@ -24,12 +24,16 @@ | |||
}, | |||
"homepage": "https://github.com/trufflesuite/truffle-deployer#readme", | |||
"dependencies": { | |||
"truffle-contract": "^3.0.5", | |||
"emittery": "^0.3.0", | |||
"truffle-contract": "git+https://github.com/trufflesuite/truffle-contract.git#8f90e82bb3e22e2da6b493d8edd217fb49d8906c", | |||
"truffle-expect": "^0.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be 'truffle-contract'
cgewecke
commented
Jun 6, 2018
src/deployment.js
Outdated
|
||
/** | ||
* Queries the confirmations mappping periodically to see if we have | ||
* heard enough confirmations for a given tx to allow `deploy` to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ppp
cgewecke
commented
Jun 6, 2018
} else { | ||
hasAddress = library.address != null; | ||
deployer.emitter.emit('error', eventArgs); | ||
throw new Error(); // <-- Handle this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n
confirmations, via truffle config. truffle 763truffle-migrate
is beginning now.Requesting preliminary review so architectural stuff can be addressed as necessary.
ERROR COHERENCE CHART
EVENTS
transactionHash
event.receipt
event.confirmation
event.