Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freezeV2): Add bandwidth cost for delegating validation #4796

Merged
merged 1 commit into from
Nov 18, 2022
Merged

feat(freezeV2): Add bandwidth cost for delegating validation #4796

merged 1 commit into from
Nov 18, 2022

Conversation

CarlChaoCarl
Copy link
Contributor

@CarlChaoCarl CarlChaoCarl commented Nov 17, 2022

What does this PR do?
Add bandwidth cost when creating delegate resource transactions for validation.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@CarlChaoCarl CarlChaoCarl changed the title feat(freezeV2): For delegate bandwidth transactions, add cost bandwid… feat(freezeV2): Add cost bandwidth when creating delegate resource transactions for validate Nov 18, 2022
@CarlChaoCarl CarlChaoCarl changed the title feat(freezeV2): Add cost bandwidth when creating delegate resource transactions for validate feat(freezeV2): Add bandwidth cost for delegating validation Nov 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4796 (62e9c1a) into feature/stake_2.0 (4afd4c5) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

@@                   Coverage Diff                   @@
##             feature/stake_2.0    #4796      +/-   ##
=======================================================
- Coverage                54.45%   54.41%   -0.04%     
+ Complexity                8436     8431       -5     
=======================================================
  Files                      866      866              
  Lines                    50022    50029       +7     
  Branches                  5521     5522       +1     
=======================================================
- Hits                     27241    27225      -16     
- Misses                   20561    20581      +20     
- Partials                  2220     2223       +3     
Impacted Files Coverage Δ
...g/tron/core/actuator/DelegateResourceActuator.java 81.42% <50.00%> (-1.06%) ⬇️
...java/org/tron/core/capsule/TransactionCapsule.java 51.20% <100.00%> (+0.23%) ⬆️
framework/src/main/java/org/tron/core/Wallet.java 18.46% <100.00%> (+0.06%) ⬆️
...n/java/org/tron/core/exception/TaposException.java 0.00% <0.00%> (-50.00%) ⬇️
.../java/org/tron/core/consensus/BlockHandleImpl.java 65.00% <0.00%> (-15.00%) ⬇️
...java/org/tron/core/store/WitnessScheduleStore.java 84.84% <0.00%> (-6.07%) ⬇️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 88.70% <0.00%> (-3.23%) ⬇️
.../common/storage/rocksdb/RocksDbDataSourceImpl.java 66.41% <0.00%> (-1.91%) ⬇️
...mework/src/main/java/org/tron/core/db/Manager.java 54.45% <0.00%> (-0.79%) ⬇️
...n/java/org/tron/core/db2/core/SnapshotManager.java 74.05% <0.00%> (-0.59%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhang0125 zhang0125 merged commit 48aa0ed into tronprotocol:feature/stake_2.0 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants