Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freezeV2): optimize unfreeze vote #4741

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

zhang0125
Copy link
Contributor

What does this PR do?

optimize unfreeze vote

  1. clear all votes at once when new resource model start
  2. If there is not enough power to vote, reduce the votes proportionally

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@zhang0125 zhang0125 force-pushed the feature/unfreeze_vote branch from 37aab3b to 04982be Compare October 27, 2022 08:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release_v4.6.0@dd5c8a3). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release_v4.6.0    #4741   +/-   ##
=================================================
  Coverage                  ?   54.76%           
  Complexity                ?     8391           
=================================================
  Files                     ?      856           
  Lines                     ?    49540           
  Branches                  ?     5480           
=================================================
  Hits                      ?    27132           
  Misses                    ?    20187           
  Partials                  ?     2221           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

1. clear all votes at once when new resource model start
2. If there is not enough power to vote, reduce the votes proportionally
@zhang0125 zhang0125 force-pushed the feature/unfreeze_vote branch from 04982be to 24f141b Compare October 28, 2022 10:12
@zhang0125 zhang0125 merged commit 79a190a into release_v4.6.0 Oct 29, 2022
@zhang0125 zhang0125 deleted the feature/unfreeze_vote branch October 29, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants