Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactor(liteFullNodeTool): refactor code #4639

Merged

Conversation

halibobo1205
Copy link
Contributor

What does this PR do?

  1. optimize exception handling
  2. extract common method

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

1. optimize exception handling
2. extract common method
@codecov-commenter
Copy link

Codecov Report

Merging #4639 (2d563eb) into release_v4.6.0 (046eab5) will increase coverage by 0.05%.
The diff coverage is 53.84%.

@@                 Coverage Diff                  @@
##             release_v4.6.0    #4639      +/-   ##
====================================================
+ Coverage             54.19%   54.25%   +0.05%     
- Complexity             7944     7956      +12     
====================================================
  Files                   831      831              
  Lines                 47123    47115       -8     
  Branches               5106     5103       -3     
====================================================
+ Hits                  25537    25560      +23     
+ Misses                19555    19528      -27     
+ Partials               2031     2027       -4     
Impacted Files Coverage Δ
...a/org/tron/tool/litefullnode/LiteFullNodeTool.java 75.25% <53.84%> (+0.34%) ⬆️
...g/tron/common/overlay/discover/DiscoverServer.java 79.03% <0.00%> (-1.62%) ⬇️
...mework/src/main/java/org/tron/core/db/Manager.java 55.99% <0.00%> (+0.62%) ⬆️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 91.93% <0.00%> (+3.22%) ⬆️
...ain/java/org/tron/consensus/dpos/StateManager.java 56.25% <0.00%> (+4.16%) ⬆️
...ain/java/org/tron/common/utils/ForkController.java 79.80% <0.00%> (+5.76%) ⬆️
...ron/tool/litefullnode/iterator/RockDBIterator.java 100.00% <0.00%> (+14.28%) ⬆️
...on/tool/litefullnode/iterator/LevelDBIterator.java 100.00% <0.00%> (+14.28%) ⬆️
.../java/org/tron/core/consensus/BlockHandleImpl.java 80.00% <0.00%> (+15.00%) ⬆️
...g/tron/core/exception/DupTransactionException.java 66.66% <0.00%> (+66.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 merged commit 7b3a97a into tronprotocol:release_v4.6.0 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants