Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new resource model #3726

Merged
merged 29 commits into from
Apr 6, 2021
Merged

Conversation

sean-liu55
Copy link
Contributor

What does this PR do?
add new resource model

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

Copy link
Contributor

@renchenchang renchenchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Apr 6, 2021

Codecov Report

Merging #3726 (e60420b) into release_v4.2 (e5f2958) will increase coverage by 0.42%.
The diff coverage is 66.87%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release_v4.2    #3726      +/-   ##
==================================================
+ Coverage           51.90%   52.32%   +0.42%     
- Complexity           6935     7029      +94     
==================================================
  Files                 765      765              
  Lines               43115    43260     +145     
  Branches             4658     4685      +27     
==================================================
+ Hits                22379    22636     +257     
+ Misses              18891    18772     -119     
- Partials             1845     1852       +7     
Impacted Files Coverage Δ Complexity Δ
common/src/main/java/org/tron/core/Constant.java 50.00% <ø> (ø) 1.00 <0.00> (ø)
framework/src/main/java/org/tron/core/Wallet.java 17.18% <0.00%> (+0.14%) 86.00 <0.00> (ø)
...ain/java/org/tron/core/services/RpcApiService.java 4.80% <0.00%> (-0.01%) 9.00 <0.00> (ø)
...rc/main/java/org/tron/core/utils/ProposalUtil.java 40.48% <33.33%> (-0.52%) 20.00 <0.00> (ø)
...ava/org/tron/common/parameter/CommonParameter.java 57.08% <50.00%> (-0.06%) 125.00 <1.00> (+1.00) ⬇️
...rg/tron/core/actuator/UnfreezeBalanceActuator.java 66.80% <52.50%> (-4.04%) 40.00 <0.00> (+7.00) ⬇️
.../org/tron/core/actuator/FreezeBalanceActuator.java 80.11% <55.55%> (-2.47%) 35.00 <0.00> (+2.00) ⬇️
.../src/main/java/org/tron/core/config/args/Args.java 69.70% <75.00%> (+0.02%) 85.00 <0.00> (ø)
...va/org/tron/core/actuator/VoteWitnessActuator.java 85.85% <87.50%> (-0.02%) 23.00 <0.00> (+2.00) ⬇️
...ain/java/org/tron/core/capsule/AccountCapsule.java 78.34% <91.17%> (+0.87%) 136.00 <13.00> (+13.00)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f2958...e60420b. Read the comment docs.

@renchenchang renchenchang merged commit f053095 into release_v4.2 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants