-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of sync & adv module #2045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto sync_restruct
…nto sync_restruct
Codecov Report
@@ Coverage Diff @@
## develop #2045 +/- ##
=============================================
- Coverage 44.78% 43.14% -1.65%
+ Complexity 4176 3994 -182
=============================================
Files 503 510 +7
Lines 29789 29462 -327
Branches 3106 3045 -61
=============================================
- Hits 13342 12712 -630
- Misses 15231 15602 +371
+ Partials 1216 1148 -68
Continue to review full report at Codecov.
|
…nto sync_restruct
…nto sync_restruct
lvs007
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor of sync & adv module
Why are these changes required?
Increase system scalability and code readability
This PR has been tested by:
Follow up
Extra details