Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of sync & adv module #2045

Merged
merged 55 commits into from
Mar 25, 2019
Merged

Refactor of sync & adv module #2045

merged 55 commits into from
Mar 25, 2019

Conversation

xxo1shine
Copy link
Contributor

What does this PR do?
Refactor of sync & adv module

Why are these changes required?
Increase system scalability and code readability

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #2045 into develop will decrease coverage by 1.64%.
The diff coverage is 26.97%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2045      +/-   ##
=============================================
- Coverage      44.78%   43.14%   -1.65%     
+ Complexity      4176     3994     -182     
=============================================
  Files            503      510       +7     
  Lines          29789    29462     -327     
  Branches        3106     3045      -61     
=============================================
- Hits           13342    12712     -630     
- Misses         15231    15602     +371     
+ Partials        1216     1148      -68
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/core/db/Manager.java 43.31% <ø> (-0.41%) 117 <0> (-2)
...ron/core/services/http/FullNodeHttpApiService.java 3.37% <ø> (ø) 2 <0> (ø) ⬇️
src/main/java/org/tron/core/config/Parameter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/org/tron/program/SolidityNode.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ava/org/tron/common/overlay/server/PeerServer.java 85.29% <ø> (-0.43%) 5 <0> (ø)
...va/org/tron/common/application/CliApplication.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/org/tron/core/services/WitnessService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/tron/common/overlay/server/MessageQueue.java 51.08% <0%> (-31.53%) 17 <0> (-15)
src/main/java/org/tron/core/Wallet.java 14.23% <0%> (ø) 42 <0> (ø) ⬇️
...n/java/org/tron/core/services/NodeInfoService.java 62.68% <0%> (+0.46%) 10 <0> (ø) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a121d3...547764c. Read the comment docs.

@olenheim olenheim merged commit caa1e79 into develop Mar 25, 2019
@shydesky shydesky deleted the sync_restruct branch November 13, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants