Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix limit types #186

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix limit types #186

merged 1 commit into from
Oct 11, 2024

Conversation

catkins-miso
Copy link
Contributor

@catkins-miso catkins-miso commented Oct 11, 2024

closes #139
require all fields in a limit to ensure that the slim processing is unambiguous/uncomplicated by dealing with optional fields

@catkins-miso catkins-miso force-pushed the 139-fix-limit-types branch 3 times, most recently from 29c2efa to 0e25b4a Compare October 11, 2024 17:52
@catkins-miso catkins-miso marked this pull request as ready for review October 11, 2024 17:53
@catkins-miso
Copy link
Contributor Author

sorry for the noise, this should be ready now

required:
- kV-min

current-with-kV:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There it is.

@getorymckeag getorymckeag merged commit bae11da into 1.0.0-wip Oct 11, 2024
3 checks passed
@getorymckeag getorymckeag deleted the 139-fix-limit-types branch October 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add kV as optional to Current type
2 participants