Fixed AAR exception required fields, added missing 415s #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catkins-miso
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Can you include an update to return the Location header in the 201 Created response to the POST /temporary-aar-exceptions
Also, I didn't remember to add 415 to the seasonal resources, so please don't close #66.
I checked and 415 is very much there on seasonal proposals. I think we should be good there. I added Location to the POSTs. |
Signed-off-by: Christopher Atkins <[email protected]>
catkins-miso
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117, #66.
Note I assume 415s will be added where needed to the new seasonal ratings paths, so the old ones were left alone.
Also corrected some HTTP statuses for delete operations that we discovered didn't make sense on implementation.