Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StructArrays to 0.7, (keep existing compat) #2165

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the StructArrays package from 0.6.11 to 0.6.11, 0.7.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2024-11-17-00-05-30-733-03201478855 branch from 437002e to 58e890a Compare November 17, 2024 00:05
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (637072a) to head (2bc9109).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2165   +/-   ##
=======================================
  Coverage   96.88%   96.88%           
=======================================
  Files         490      490           
  Lines       39491    39491           
=======================================
  Hits        38257    38257           
  Misses       1234     1234           
Flag Coverage Δ
unittests 96.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede sloede enabled auto-merge (squash) November 17, 2024 04:39
@sloede sloede disabled auto-merge November 17, 2024 04:39
sloede
sloede previously approved these changes Nov 17, 2024
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it is not yet picked up in CI. What's our policy on how to proceed here, @ranocha?

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait until upstream packages update their dependencies so that we can test the new version here.

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StructArrays.jl v0.7.0 is now picked up correctly. So from my point of view this can be merged.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be quite some confusion about which version of StructArrays.jl shall we continued in the future, see JuliaArrays/StructArrays.jl#321
However, it seems to be fair to merge this PR

@ranocha ranocha merged commit 72c0571 into main Feb 11, 2025
39 checks passed
@ranocha ranocha deleted the compathelper/new_version/2024-11-17-00-05-30-733-03201478855 branch February 11, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants