-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for StructArrays to 0.7, (keep existing compat) #2165
CompatHelper: bump compat for StructArrays to 0.7, (keep existing compat) #2165
Conversation
437002e
to
58e890a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 490 490
Lines 39491 39491
=======================================
Hits 38257 38257
Misses 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it is not yet picked up in CI. What's our policy on how to proceed here, @ranocha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to wait until upstream packages update their dependencies so that we can test the new version here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StructArrays.jl v0.7.0 is now picked up correctly. So from my point of view this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be quite some confusion about which version of StructArrays.jl shall we continued in the future, see JuliaArrays/StructArrays.jl#321
However, it seems to be fair to merge this PR
This pull request changes the compat entry for the
StructArrays
package from0.6.11
to0.6.11, 0.7
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.