Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND] [BC Breaking] Require global variables to be insantiated as constexpr ob… #5961

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[FRONTEND] [BC Breaking] Require global variables to be insantiated as constexpr ob… #5961

wants to merge 4 commits into from

Conversation

zahimoud
Copy link
Contributor

No description provided.

@zahimoud zahimoud requested a review from ptillet as a code owner February 19, 2025 00:09
@zahimoud zahimoud requested a review from ThomasRaoux February 19, 2025 00:09
ThomasRaoux
ThomasRaoux reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, let's mark it as BC breaking

@zahimoud zahimoud changed the title [FRONTEND] Require global variables to be insantiated as constexpr ob… [FRONTEND] [BC Breaking] Require global variables to be insantiated as constexpr ob… Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux left review comments

@pawelszczerbuk pawelszczerbuk pawelszczerbuk approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zahimoud @ThomasRaoux @pawelszczerbuk