Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for clang + macosx #173

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Small fixes for clang + macosx #173

merged 4 commits into from
Oct 30, 2024

Conversation

digantdesai
Copy link
Collaborator

Tested on vanilla macbook setup with the following

DISABLE_OPENMP=1 \
CC=$(which clang) \
TRITON_CPU_BACKEND=1 \
$(which python3) \
python/tutorials/01-vector-add.py

minjang
minjang approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@minjang minjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a minor refactoring suggestion.

@digantdesai digantdesai marked this pull request as ready for review October 29, 2024 18:21
@digantdesai digantdesai requested a review from ptillet as a code owner October 29, 2024 18:21
@digantdesai digantdesai merged commit 162e1c4 into main Oct 30, 2024
2 checks passed
@digantdesai digantdesai deleted the macos_fixes_2 branch October 30, 2024 17:58
int3 pushed a commit that referenced this pull request Dec 6, 2024
@digantdesai @int3
Small fixes for clang + macosx (#173)
474cbd4
ienkovich pushed a commit that referenced this pull request Dec 6, 2024
@digantdesai @ienkovich
Small fixes for clang + macosx (#173)
8bd6314
Devjiu pushed a commit to Devjiu/triton-cpu that referenced this pull request Feb 20, 2025
@digantdesai @Devjiu
Small fixes for clang + macosx (triton-lang#173)
4a778e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minjang minjang minjang approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digantdesai @minjang