Update CMakeLists to allow Jetson container build #89
Conversation
dyastremsky
force-pushed
the
dyas-jetson-alt
branch
from
1dcc9f0 to
493b59d
Compare
dyastremsky
force-pushed
the
dyas-jetson-alt
branch
from
e7a69d9 to
c97ea61
Compare
|
Requesting reapproval due to rebasing. |
| @@ -33,6 +33,8 @@ project(tritontensorflowbackend LANGUAGES C CXX) | |||
| # | |||
| option(TRITON_ENABLE_GPU "Enable GPU support in backend." ON) | |||
| option(TRITON_ENABLE_STATS "Include statistics collections in backend." ON) | |||
| option(TRITON_JETSON_BUILD "Build for Jetson. " OFF) | |||
| option(TRITON_TENSORFLOW_LICENSE_AVAILABLE "Whether the TensorFlow license is available in this build. " ON) | |||
There was a problem hiding this comment.
This should not be an option. We should always include the license to comply with Apache 2.0.
There was a problem hiding this comment.
Please see the conversations here for the context of why this is here: #89 (comment) and #89 (comment).
I'm not sure what a good alternative would be. Since it's not included in the l4t containers as far as I know, we could probably clone it from elsewhere like GitHub if that's acceptable.
|
Closing this PR. It looks like we no longer need it. Right now, we use the --no-container-build inside a Jetson container to produce the Jetson Docker containers. If we shift to using a container-build directly, we can reference this PR, as these changes will be needed for that build. |
The l4t Jetson containers store TensorFlow files in a different location. This pull request allows the user to pass a Jetson build flag to allow the build to look for files in the TensorFlow location on l4t.