Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix error-masking bug and improve debugability in L0_trace #7930

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

rmccorm4
Copy link
Contributor

Changes:

  • Remove invalid check for trace_mode after expected error that always produced RET=1 because the curl.out only contained {"error": ...} but we checked for trace_mode count to be non-zero
  • Remove RET=0 reset in middle of script - this was masking the error above
  • Add 'cat curl.out' to various places that check the contents and may fail for easier visibility to error in logs. I had to repro the first 2 bullets locally to understand what was happening, so adding this to dump out the curl responses so we can better determine what

…for trace_mode after expected error, (3) Add 'cat curl.out' to various places that check the contents and may fail for easier visibility to error in logs
@rmccorm4 rmccorm4 changed the title ci: Fix bug and improve debugability in L0_trace ci: Fix error-masking bug and improve debugability in L0_trace Jan 13, 2025
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, conditional on ci

@rmccorm4
Copy link
Contributor Author

Job passed ✅

@rmccorm4 rmccorm4 merged commit 2be6f90 into main Jan 13, 2025
3 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick/ci/L0_trace branch January 13, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants