Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Validate request correlation ID data type #7919

Merged
merged 2 commits into from
Jan 8, 2025
Merged

test: Validate request correlation ID data type #7919

merged 2 commits into from
Jan 8, 2025

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jan 7, 2025 •
edited
Loading

What does the PR do?

  1. Add unit tests to validate input correlation ID data type.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/core#425

Where should the reviewer start?

triton-inference-server/core#425

Test plan:

  • L0_sequence_corrid_batcher

  • CI Pipeline ID:
    22217066

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh added the PR: fix A bug fix label Jan 7, 2025
@yinggeh yinggeh self-assigned this Jan 7, 2025
@yinggeh yinggeh added PR: test Adding missing tests or correcting existing test and removed PR: fix A bug fix labels Jan 7, 2025
@yinggeh yinggeh mentioned this pull request Jan 7, 2025
Merged
11 tasks
@yinggeh yinggeh changed the title fix: Validate correlation ID data type test: Validate request correlation ID data type Jan 7, 2025
@yinggeh yinggeh requested a review from rmccorm4 January 8, 2025 07:16
rmccorm4
rmccorm4 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update 2025 copyrights in the core PR as well

@yinggeh yinggeh merged commit 48e615d into main Jan 8, 2025
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7531-correlation-id-data-type branch January 8, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees

@yinggeh yinggeh

Labels
PR: test Adding missing tests or correcting existing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @rmccorm4