build: Update OpenVINO model generation version #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinggeh
added
the
PR: build
yinggeh
commented
Nov 18, 2024
| @@ -2486,8 +2489,7 @@ def create_fixed_models( | |||
| import torch | |||
| from torch import nn | |||
| if FLAGS.openvino: | |||
| from openvino.inference_engine import IENetwork | |||
| import ngraph as ng | |||
There was a problem hiding this comment.
The nGraph API is deprecated and will be removed in the 2024.0 release. See opencv/opencv#24589
|
Is the linked pipeline up to date? The one mentioned in the PR didn't run mentioned tests |
Hi @oandreeva-nv. Thanks. The latest pipeline was in the slack review thread. I just updated the pipeline ID in this PR. |
oandreeva-nv
approved these changes
Nov 26, 2024
yinggeh
deleted the
yinggeh-DLIS-7598-openvino-version-update-model-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Triton uses OpenVINO version 2024 however our models still generated with version 2023.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
L0_openvino_models--base
L0_model_config--base
20542122
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)