Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding tests for numpy>=2 #7756

Merged
merged 11 commits into from
Nov 1, 2024
Prev Previous commit
Next Next commit
spacing
  • Loading branch information
KrishnanPrash committed Oct 30, 2024
commit fb3e0f8f601ca55cb1a8beace4f78c7f2c71d4e1
3 changes: 2 additions & 1 deletion qa/L0_backend_python/examples/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ source ../common.sh
source ../../common/util.sh

TRITON_REPO_ORGANIZATION=${TRITON_REPO_ORGANIZATION:="http://github.com/triton-inference-server"}

SERVER_ARGS="--model-repository=${MODELDIR}/examples/python_backend/models --backend-directory=${BACKEND_DIR} --log-verbose=1"
SERVER_LOG="./examples_server.log"

Expand Down Expand Up @@ -441,6 +442,6 @@ else
echo -e "\n***\n*** Example verification test FAILED.\n***"
fi

pip3 uninstall numpy
pip3 uninstall -y numpy
pip3 install "numpy<2"
Copy link
Contributor Author

@KrishnanPrash KrishnanPrash Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In L0_backend_python, the way examples/test.sh is called is along the lines of:

    setup_virtualenv

    set +e
    (cd ${TEST} && bash -ex test.sh)

    if [ $? -ne 0 ]; then
        echo "Subtest ${TEST} FAILED"
        RET=1
    fi
    set -e

    deactivate_virtualenv

So re-installing a lower version of numpy is unnecessary here because the virtualenv created for the examples subtest is not re-used for future subtests.

exit $RET