Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Include job id and nightly tag to results uploaded #7751

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Oct 28, 2024

What does the PR do?

Include job id and nightly tag together with the results uploaded.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

N/A

  • CI Pipeline ID: 19882967

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui self-assigned this Oct 28, 2024
@kthui kthui force-pushed the jacky-perf-annotation branch from 999bd50 to 8cd544b Compare October 29, 2024 21:36
@kthui kthui added the PR: refactor A code change that neither fixes a bug nor adds a feature label Oct 31, 2024
@kthui kthui changed the title Include job id and nightly tag to results uploaded refactor: Include job id and nightly tag to results uploaded Oct 31, 2024
@kthui kthui marked this pull request as ready for review October 31, 2024 21:31
@kthui kthui merged commit 97405fd into main Oct 31, 2024
3 checks passed
@kthui kthui deleted the jacky-perf-annotation branch October 31, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: refactor A code change that neither fixes a bug nor adds a feature
Development

Successfully merging this pull request may close these issues.

2 participants