Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix L0_perf_nomodel shared memory #7709

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Oct 16, 2024

What does the PR do?

Fix L0_perf_nomodel shared memory test - system and cuda.

  • Update flag name BENCHMARK_TEST_SHARED_MEMORY to TEST_SHARED_MEMORY.
  • Correctly set the --output-shared-memory-size flag for perf analyzer.

Root cause:

  • The CI runners were re-configured to set TEST_SHARED_MEMORY instead of BENCHMARK_TEST_SHARED_MEMORY, causing the system/CUDA shared memory tests to run as non-shared memory test, resulting in no data reported for both shared memory tests since the re-configuration.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

N/A

  • CI Pipeline ID: 19429907

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui added the PR: fix A bug fix label Oct 16, 2024
@kthui kthui force-pushed the jacky-fix-perf-nomodel-shm branch from a7bae0c to 6cef49b Compare October 16, 2024 20:47
@kthui kthui force-pushed the jacky-fix-perf-nomodel-shm branch from 6cef49b to 6aba9aa Compare October 17, 2024 00:39
@kthui kthui marked this pull request as ready for review October 18, 2024 00:50
@kthui kthui requested review from rmccorm4 and indrajit96 October 18, 2024 00:50
Copy link
Contributor

@indrajit96 indrajit96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the RCA of tests not completing either on the bug or PR description?

@kthui
Copy link
Contributor Author

kthui commented Oct 18, 2024

Sure, added root cause to the description.

@indrajit96
Copy link
Contributor

Just a FYI, we might need to edit these test soon one the PA fixes for C API and PA Hang are done.
LGTM for now. Approving,

@indrajit96 indrajit96 closed this Oct 18, 2024
@indrajit96 indrajit96 reopened this Oct 18, 2024
qa/L0_perf_nomodel/test.sh Show resolved Hide resolved
@kthui
Copy link
Contributor Author

kthui commented Oct 18, 2024

I will merge to main first. We can file additional tickets if there are breakages with the PA fixes.

@kthui kthui merged commit 088d9a9 into main Oct 18, 2024
5 checks passed
@kthui kthui deleted the jacky-fix-perf-nomodel-shm branch October 18, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix A bug fix
Development

Successfully merging this pull request may close these issues.

2 participants