Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Adding tritonfrontend to build.py #7681

Merged
merged 7 commits into from
Oct 9, 2024
Merged

build: Adding tritonfrontend to build.py #7681

merged 7 commits into from
Oct 9, 2024

Conversation

KrishnanPrash
Copy link
Contributor

What does the PR do?

With this addition to build.py the tritonfrontend wheel will be populated in /opt/tritonserver/python alongside the tritonserver wheel.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • [] Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

@KrishnanPrash KrishnanPrash added the PR: build Changes that affect the build system or external dependencies label Oct 4, 2024
rmccorm4
rmccorm4 reviewed Oct 4, 2024
View reviewed changes
build.py Outdated Show resolved Hide resolved
rmccorm4
rmccorm4 reviewed Oct 4, 2024
View reviewed changes
build.py Outdated Show resolved Hide resolved
KrishnanPrash and others added 2 commits October 4, 2024 16:49
@KrishnanPrash @rmccorm4
Update build.py
d1b5551 
Co-authored-by: Ryan McCormick <[email protected]>
@KrishnanPrash @rmccorm4
Update build.py
dc02efe 
Co-authored-by: Ryan McCormick <[email protected]>
@KrishnanPrash KrishnanPrash requested a review from rmccorm4 October 4, 2024 23:50
rmccorm4
rmccorm4 previously approved these changes Oct 5, 2024
View reviewed changes
@rmccorm4 rmccorm4 requested a review from GuanLuo October 5, 2024 00:11
GuanLuo
GuanLuo previously approved these changes Oct 6, 2024
View reviewed changes
@KrishnanPrash KrishnanPrash dismissed stale reviews from GuanLuo and rmccorm4 via c0aba00 October 8, 2024 19:46
@rmccorm4
Copy link
Contributor

rmccorm4 commented Oct 9, 2024 •
edited
Loading

As a reuslt of this change, now the tritonfrontend*.whl will be in the container alongside the tritonserver*.whl in /opt/tritonserver/python.

image

@KrishnanPrash KrishnanPrash merged commit fde6e58 into main Oct 9, 2024
3 checks passed
@KrishnanPrash KrishnanPrash deleted the kprashanth-tritonfrontend-build branch October 9, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@GuanLuo GuanLuo GuanLuo left review comments

@kthui kthui Awaiting requested review from kthui

Assignees

@KrishnanPrash KrishnanPrash

Labels
PR: build Changes that affect the build system or external dependencies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrishnanPrash @rmccorm4 @GuanLuo