Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add python backend to windows build command #7572

Merged
merged 1 commit into from
Aug 27, 2024
Merged

docs: Add python backend to windows build command #7572

merged 1 commit into from
Aug 27, 2024

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Aug 27, 2024 •
edited
Loading

What does the PR do?

Add python backend to windows build build.py command.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@krishung5 krishung5 requested a review from fpetrini15 August 27, 2024 18:01
@krishung5 krishung5 added the PR: docs Documentation only changes label Aug 27, 2024
fpetrini15
fpetrini15 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@krishung5 krishung5 merged commit 96144e0 into main Aug 27, 2024
3 checks passed
@krishung5 krishung5 deleted the krish-doc branch August 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetrini15 fpetrini15 fpetrini15 approved these changes

Assignees
No one assigned
Labels
PR: docs Documentation only changes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishung5 @fpetrini15