PA Migration: Update L0_client_build_variants #7505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of
L0_client_build_variants
is to build client libraries/binaries by enabling/disabling various optional features and verify that the build succeeds.One such set of combinations is to enable/disable optional PA features and verify the build succeeds. This test had been passing (false positive) despite running with a client branch that purged PA from the client repo. Examining the logs closer, it was because CMake was simply ignoring PA-related parameters and repeatedly performing the same standard cc-client/python-client build:
These changes modify the script to point to PA source code that recognizes these optional parameters, restoring the test's original purpose.
Ideally, these tests will eventually be moved out of Triton CI entirely and into PA CI.