test: Improve L0_logging stability #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection errors before frontends become available
rmccorm4
changed the title
krishung5
reviewed
Jul 30, 2024
| @@ -60,6 +60,11 @@ source ../common/util.sh | |||
| rm -f *.log | |||
| rm -fr $MODELSDIR && mkdir -p $MODELSDIR | |||
|
|
|||
| if [ ! -d ${DATADIR} ]; then | |||
There was a problem hiding this comment.
Is this check added just to let us know if the model repository in the dlcluster is not setup correctly? or if there's other cases that we want to catch?
There was a problem hiding this comment.
I ran the test locally with a non-existing datadir and the test ran and failed much later with obscure errors, but was actually missing one of the models -- so just to catch low hanging fruit later on for future debuggers
krishung5
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adds more graceful handling to server startup given the way it's launched in the L0_logging test.
Current test is failing intermittently with call to
client.is_server_ready()raising anExceptionon a failed connection. This can happen if the frontends aren't ready and accepting requests yet while server is still starting up.This PR:
DATADIRisn't set correctly to smooth local testingChecklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Test plan:
L0_logging