ci: Return custom exit code to indicate known shm leak failure in L0_backend_python bls test #7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
Jul 30, 2024
krishung5
changed the title
krishung5
added
PR: ci
rmccorm4
reviewed
Jul 30, 2024
| @@ -151,7 +151,7 @@ apt-get update && apt-get -y install \ | |||
| libboost-dev | |||
| rm -f /usr/bin/python3 && \ | |||
| ln -s "/usr/bin/python3.${PYTHON_ENV_VERSION}" /usr/bin/python3 | |||
| pip3 install --upgrade install requests numpy virtualenv protobuf | |||
rmccorm4
reviewed
Jul 30, 2024
qa/common/shm_util.py
Outdated
| @@ -441,6 +441,9 @@ def __exit__(self, type, value, traceback): | |||
| print( | |||
| f"Shared memory leak detected [{shm_region}]: {curr_shm_free_size} (curr free) < {prev_shm_free_size} (prev free)." | |||
| ) | |||
| # Known shared memory leak of 480 bytes in BLS test. | |||
There was a problem hiding this comment.
Do we have any ticket to eventually find/resolve this issue all together? Would be good to leave the FIXME DLIS-XXXX here if so.
There was a problem hiding this comment.
Good call, added the ticket reference.
rmccorm4
reviewed
Jul 30, 2024
rmccorm4
approved these changes
Jul 31, 2024
kthui
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Return custom exit code
123to indicate known shm leak failure in L0_backend_python bls test. CI will catch the custom exit code and allow the L0_backend_python test to fail if the known issues occur.In order to propagate the exit code correctly, Python unittest and Pytest can not be used at the same time. In this PR, the
python_unittest.pyis replaced withtest_infer_shm_leak.pywhich uses Pytest directly.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
tritonserver MR !236.
Where should the reviewer start?
Test plan:
L0_backend_python should fail with
allowed to failif it's failing due to the known shm leak from bls sub test.Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)