Fix benchmarking tests #7461
Merged
Fix benchmarking tests #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's out of scope for this PR, but it looks like there are some functions like |
mc-nv
reviewed
Jul 23, 2024
| else | ||
| echo "Installed Open MPI version is not less than 5.0.1. Skipping the upgrade." | ||
| echo "The installed Open MPI version ($CURRENT_VERSION) is 5.0.1 or higher. Skipping the upgrade." |
There was a problem hiding this comment.
DLFW uses specific version of Open MPI, by mocking and upgrading version within test we cause precedent that we start testing something that is won't be shipped to the customers.
krishung5
reviewed
Aug 9, 2024
| cd $TENSORRTLLM_BACKEND_DIR && git lfs install && git submodule update --init --recursive | ||
| } | ||
|
|
||
| # Update Open MPI to a version compatible with SLURM. | ||
| function upgrade_openmpi { | ||
| cd /tmp/ | ||
| local CURRENT_VERSION=$(mpirun --version 2>&1 | awk '/Open MPI/ {gsub(/rc[0-9]+/, "", $NF); print $NF}') | ||
|
|
||
| if [ -n "$CURRENT_VERSION" ] && dpkg --compare-versions "$CURRENT_VERSION" lt "5.0.1"; then | ||
| # Uninstall the current version of Open MPI |
There was a problem hiding this comment.
I understand that this is due to the SLURM MPI limitation, but agree with Misha's comment that we should be using the exact same version of the one shipped in the container. Can be future enhancement.
pvijayakrish
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 5320009.
mc-nv
pushed a commit
that referenced
this pull request
Aug 16, 2024
pvijayakrish
added a commit
that referenced
this pull request
Jan 15, 2025
This reverts commit a5ad309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
L0_perf_tensorrt_llmL0_perf_vllmChecklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)