Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: Bumping vllm version to v0.5.3.post1 #7453

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

oandreeva-nv
Copy link
Contributor

What does the PR do?

Bumping vllm version to the latest.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

vllm_backend : triton-inference-server/vllm_backend#47

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 16687396

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@oandreeva-nv oandreeva-nv added the PR: build Changes that affect the build system or external dependencies label Jul 17, 2024
rmccorm4
rmccorm4 previously approved these changes Jul 18, 2024
build.py Outdated
@@ -76,7 +76,7 @@
"2024.0.0", # ORT OpenVINO
"2024.0.0", # Standalone OpenVINO
"3.2.6", # DCGM version
"0.5.0.post1", # vLLM version
"v0.5.3.post1", # vLLM version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the v be included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll remove it for consistency with previous specs. CI passed though with pip install vllm==v0.5.3.post1 though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I didn't know it would work both ways, just thought it was a typo. No preference either way if it works.

@rmccorm4 rmccorm4 changed the title [build]: Bumping vllm version to 0.5.2 [build]: Bumping vllm version to v0.5.3.post1 Jul 25, 2024
@oandreeva-nv oandreeva-nv merged commit aca16ba into main Jul 25, 2024
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_vllm_0.5.2 branch July 25, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies
Development

Successfully merging this pull request may close these issues.

3 participants