-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Downgrade ompi version to v4.1.5rc2 #7441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix 🚀
@fpetrini15 FYI - though the TRT-LLM team says there shouldn't be issues for the downgrade, they are still trying to verify if there is any perf regression. Might worth waiting for their verification to merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissing approval until the TRT-LLM team verifies the fix
Rebased |
Downgrade ompi version to v4.1.5rc2
What does the PR do?
Downgrade ompi version to avoid ucc issues when running TRT-LLM container on kubernetes.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
TRT-LLM backend build and tests should be passing.
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)