Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error message for L0_trt_compat #7432

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Jul 9, 2024

What does the PR do?

It seems like the error message from TRT might have changed from

Internal Error (Cannot deserialize engine...

to

API Usage Error (Cannot deserialize engine...

This PR fixes the expected error message for L0_trt_compat test so that the expected error message matches to the actual error message.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 16446460

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@krishung5 krishung5 added PR: ci Changes to our CI configuration files and scripts PR: fix A bug fix labels Jul 9, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@krishung5 krishung5 merged commit ac0d4d6 into main Jul 10, 2024
3 checks passed
@krishung5 krishung5 deleted the krish-fix-trt-compat branch July 10, 2024 17:37
fpetrini15 pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ci Changes to our CI configuration files and scripts PR: fix A bug fix
Development

Successfully merging this pull request may close these issues.

2 participants