[refactor]: Refactor Frontend Trace OpenTelemetry Implementation #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandreeva-nv
added
module: server
GuanLuo
reviewed
Jun 28, 2024
|
|
||
| /// Adds event to the span on the top of the stack, related to trace | ||
| /// with `trace_id`. If activity is TRITONSERVER_TRACE_REQUEST_START, | ||
| /// or TRITONSERVER_TRACE_COMPUTE_START, starts a new span and adds it |
There was a problem hiding this comment.
Why not let caller use StartSpan for those event?
There was a problem hiding this comment.
Could you please clarify?
Tabrizian
reviewed
Jul 2, 2024
|
@Tabrizian this is just a re-factor for the frontend. The actual custom backend implementation PR will be up shortly |
Co-authored-by: Iman Tabrizian <[email protected]>
oandreeva-nv
force-pushed
the
oandreeva-trace-refactor
branch
from
6b60d93 to
864cc75
Compare
20 tasks
GuanLuo
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR introduces an improvement to our frontend OpenTelemetry tracing implementation. The main goal of this refactoring is to enhance the reliability and flexibility of the system.
Key Changes:
parent_idfor every trace, I utilize this and introduced an unordered map to keep spans in stacks. Each trace and sub-trace has its own stack. When stack is empty, I useparent_idto check the top of the parent's stack to get parent span's information.Custom backend tracingimplementation to avoid handling of the complex logic for multiple nested custom spans, i.e. we simply look at the top of the stack.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
N/A
Where should the reviewer start?
trace.h
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A