Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "Change TensorRT-LLM (#7143)" #7341

Merged
merged 9 commits into from
Jun 17, 2024
Merged

revert: "Change TensorRT-LLM (#7143)" #7341

merged 9 commits into from
Jun 17, 2024

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Jun 12, 2024

What does the PR do?

Some changes were made to improve the TRT-LLM backend build process. However, for Triton 24.06 release, we will be using TRT-LLM backend release/0.10, which doesn't have the corresponded changes.
This PR reverts commit b14abd4 and fixing some dependencies versions for TRT-LLM release/0.10.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

The pipeline for TRT-LLM backend build and tests should be passing.

  • CI Pipeline ID: 15809925

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@krishung5 krishung5 changed the title Revert "Change TensorRT-LLM (#7143)" revert: "Change TensorRT-LLM (#7143)" Jun 12, 2024
@krishung5 krishung5 added the PR: build Changes that affect the build system or external dependencies label Jun 12, 2024
@krishung5 krishung5 marked this pull request as ready for review June 13, 2024 19:57
@krishung5 krishung5 added the PR: ci Changes to our CI configuration files and scripts label Jun 13, 2024
@krishung5 krishung5 requested review from tanmayv25 and rmccorm4 June 13, 2024 22:38
@nv-kmcgill53 nv-kmcgill53 merged commit 833f2b9 into r24.06 Jun 17, 2024
3 checks passed
@nv-kmcgill53 nv-kmcgill53 deleted the krish-r24.06 branch June 17, 2024 20:05
mc-nv pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies PR: ci Changes to our CI configuration files and scripts
Development

Successfully merging this pull request may close these issues.

3 participants