Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics model namespacing label test #7141

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add metrics model namespacing label test #7141

merged 2 commits into from
Apr 26, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Apr 19, 2024 •
edited
Loading

Related PR: triton-inference-server/core#343

Add test to ensure "namespace" label exists on metrics when the server is launched with --model-namespacing=true.

@kthui kthui mentioned this pull request Apr 19, 2024
Merged
@kthui kthui force-pushed the jacky-metric-namespace branch from c3047fb to 114c890 Compare April 22, 2024 16:41
@kthui kthui marked this pull request as ready for review April 22, 2024 17:22
oandreeva-nv
oandreeva-nv reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check that for default behavior (assuming it is model-namespacing=false), namespacing label is not present?

@kthui
Copy link
Contributor Author

kthui commented Apr 24, 2024

Add test for namespace off

Sure. Add test for namespace off

oandreeva-nv
oandreeva-nv approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@oandreeva-nv oandreeva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kthui kthui merged commit c8e4fb6 into main Apr 26, 2024
3 checks passed
@kthui kthui deleted the jacky-metric-namespace branch April 26, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandreeva-nv oandreeva-nv oandreeva-nv approved these changes

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

@Tabrizian Tabrizian Awaiting requested review from Tabrizian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kthui @oandreeva-nv