Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable PA trace testing but remove setting trace file #7131

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Re-enable PA trace testing but remove setting trace file #7131

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
012aeab
Re-enable PA trace testing but remove setting trace file
matthewkotila Apr 18, 2024
33c5d4c
Address feedback
matthewkotila Apr 18, 2024
36d9fbc
Address feedback
matthewkotila Apr 18, 2024
b84d09a
Address feedback
matthewkotila Apr 18, 2024
4d7c8e5
Fix bug
matthewkotila Apr 18, 2024
e49682f
Address feedback
matthewkotila Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion qa/L0_perf_analyzer/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ SEQ_WRONG_OUTPUT_JSONDATAFILE=`pwd`/../common/perf_analyzer_input_data_json/seq_
REPEAT_INT32_JSONDATAFILE=`pwd`/../common/perf_analyzer_input_data_json/repeat_int32_data.json

SERVER=/opt/tritonserver/bin/tritonserver
SERVER_ARGS="--model-repository=${DATADIR}"
SERVER_ARGS="--model-repository=${DATADIR} --trace-config triton,file=trace.json"
SERVER_LOG="./inference_server.log"

ERROR_STRING="error | Request count: 0 | : 0 infer/sec"
Expand Down Expand Up @@ -639,6 +639,30 @@ for PROTOCOL in grpc http; do
fi
set -e
done

# Testing that trace logging works
set +e
curl localhost:8000/v2/trace/setting -d '{"trace_level":["TIMESTAMPS"]}'
rmccorm4 marked this conversation as resolved.
Show resolved Hide resolved
TRACE_FILE="trace.json"
rmccorm4 marked this conversation as resolved.
Show resolved Hide resolved
rm ${TRACE_FILE}*
$PERF_ANALYZER -v -i $PROTOCOL -m simple_savedmodel_sequence_object -p 2000 -t5 --sync \
rmccorm4 marked this conversation as resolved.
Show resolved Hide resolved
--trace-level TIMESTAMPS --trace-rate 1000 --trace-count 100 --log-frequency 10 \
--input-data=$SEQ_JSONDATAFILE -s ${STABILITY_THRESHOLD} >$CLIENT_LOG 2>&1
if [ $? -ne 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Failed\n***"
RET=1
fi
if ! compgen -G "$TRACE_FILE*" > /dev/null; then
echo -e "\n***\n*** Test Failed. $TRACE_FILE failed to generate.\n***"
RET=1
elif [ $(cat ${TRACE_FILE}* | grep "REQUEST_START" | wc -l) -eq 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Failed. Did not find `REQUEST_START` in $TRACE_FILE \n***"
RET=1
fi
curl localhost:8000/v2/trace/setting -d '{"trace_level":["OFF"]}'
set -e
done

# Test with output validation
Expand Down
Loading